Aias00 opened a new issue, #10726:
URL: https://github.com/apache/rocketmq/issues/10726

   ## Problem
   
   `HeartbeatSyncer.consumeMessage` logs the full `MessageExt` and raw message 
body when heartbeat sync message parsing or processing fails:
   
   ```java
   log.error("heartbeat consume message failed. msg:{}, data:{}", msg, new 
String(msg.getBody(), StandardCharsets.UTF_8), t);
   ```
   
   The body contains serialized heartbeat synchronization data, including 
client identity and subscription metadata. Logging the raw body is unnecessary 
for diagnostics and can expose operational metadata in proxy logs.
   
   ## Scope
   
   Track 2 / Proxy runtime diagnostics hardening. This is a logging-safety 
change only; heartbeat sync behavior should remain unchanged.
   
   ## Expected behavior
   
   - Do not log raw heartbeat sync message body on failure.
   - Keep useful diagnostics such as topic, messageId, body size, and parsed 
heartbeat summary when available.
   - Add targeted coverage for the summary helper so raw payload fields are not 
emitted.
   
   ## Evidence
   
   - 
`proxy/src/main/java/org/apache/rocketmq/proxy/service/sysmessage/HeartbeatSyncer.java`
 logs `new String(msg.getBody(), StandardCharsets.UTF_8)` in the catch block.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to