Aias00 opened a new issue, #10728:
URL: https://github.com/apache/rocketmq/issues/10728

   ## Problem
   
   `ConsumerProcessor.filterPopResult` logs `MessageExt` directly in two error 
paths:
   
   ```java
   log.error("[BUG] pop message from broker but handle is empty. 
requestHeader:{}, msg:{}", requestHeader, messageExt);
   log.error("process filterMessage failed. requestHeader:{}, msg:{}", 
requestHeader, messageExt, t);
   ```
   
   `MessageExt.toString()` delegates to `Message.toString()`, which prints 
`Arrays.toString(body)`. These logs can expose message payload bytes when POP 
filtering or handle creation fails.
   
   ## Scope
   
   Track 2 / Proxy runtime diagnostics hardening. This should only change log 
content, not POP filtering behavior.
   
   ## Expected behavior
   
   - Do not log raw `MessageExt` objects in `ConsumerProcessor` error paths.
   - Keep useful diagnostics such as topic, msgId, queueId, queueOffset, body 
size, and property keys.
   - Add targeted test coverage for the message summary helper.
   
   ## Evidence
   
   - 
`proxy/src/main/java/org/apache/rocketmq/proxy/processor/ConsumerProcessor.java`
 logs `messageExt` directly.
   - 
`common/src/main/java/org/apache/rocketmq/common/message/Message.java#toString` 
includes `Arrays.toString(body)`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to