123123213weqw opened a new pull request, #750: URL: https://github.com/apache/rocketmq-dashboard/pull/750
Fixes #686 ### Problem `DLQProviderStub` is wired as the production `DLQProvider`, but it: - returns **hard-coded sample DLQ groups** from `listDLQGroups`, and - treats `resendMessages` as a **no-op** (only logs, never resends). Returning sample data and successful no-op responses can mislead operators into believing real DLQ groups exist and that resend requests actually succeeded. ### Fix Until a real DLQ provider is connected, both operations now **fail explicitly** with a structured `501 Not Implemented` `BusinessException` (which `GlobalExceptionHandler` maps to a clean `Result.error(501, ...)` response), as the issue's "Expected" section calls for. The hard-coded stub data and its helper methods are removed. `DLQProviderStubTest` is updated to assert the new not-implemented behavior. ### Verification `mvn test -Dtest=DLQProviderStubTest` passes on JDK 21: `Tests run: 3, Failures: 0, Errors: 0, Skipped: 0`. ### Diff 2 files changed, +28 / -85. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
