ai-yang opened a new pull request, #10753: URL: https://github.com/apache/rocketmq/pull/10753
## Summary - invoke `operationSucceed` or `operationFail` before `operationComplete`, as required by the `InvokeCallback` contract - keep invocation failures separate from exceptions thrown by user callback code - preserve unwrapping of the original remoting failure - add deterministic success, failure, ordering, and callback-exception regressions ## Root cause `invokeAsyncImpl` chained `whenComplete`, `thenAccept`, and `exceptionally`. That made `operationComplete` run first and allowed exceptions from callback methods to flow into the invocation-failure stage. The fix handles the original invocation result in one terminal `whenComplete` callback and invokes final completion in `finally`. ## Validation - affected callback regressions: 20 isolated JDK 8 Maven processes, 5/5 each (100/100) - full remoting reactor - full common reactor - full client reactor - Checkstyle - SpotBugs - Maven validate - `git diff --check` Fixes #10747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
