lizhimins commented on PR #751: URL: https://github.com/apache/rocketmq-dashboard/pull/751#issuecomment-5161743363
Thanks for the contribution. This is already covered by #685, merged into `rocketmq-studio` as 02e7bed: `MessageProviderStub.queryMessages` and `getMessageTrace` now both throw `BusinessException(501, ...)` instead of returning empty results, and `MessageProviderStubTest` asserts the 501 behaviour. #685 was opened first, so it was merged under first-come-first-served review order. Two details from your version were not carried over, and a small follow-up PR would be welcome if you think they are worth it: per-method messages (`Message query ...` vs `Message trace ...`) instead of one shared message, and the class-level Javadoc explaining why empty results are misleading. Please keep the `@Slf4j` warn logs, though — they are useful when diagnosing a deployment that still runs the stub. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
