This is an automated email from the ASF dual-hosted git repository.
lizhimins pushed a commit to branch rocketmq-studio
in repository https://gitbox.apache.org/repos/asf/rocketmq-dashboard.git
The following commit(s) were added to refs/heads/rocketmq-studio by this push:
new 654283de fix: start K8s cert repository empty (#705)
654283de is described below
commit 654283def723d10280e760f88498c34c547340fe
Author: aias00 <[email protected]>
AuthorDate: Sun Aug 2 20:10:46 2026 -0700
fix: start K8s cert repository empty (#705)
---
.../cluster/k8s/InMemoryK8sCertRepository.java | 63 ---------------------
.../cluster/k8s/InMemoryK8sCertRepositoryTest.java | 64 ++++++++++++++++++++++
2 files changed, 64 insertions(+), 63 deletions(-)
diff --git
a/server/src/main/java/org/apache/rocketmq/studio/cluster/k8s/InMemoryK8sCertRepository.java
b/server/src/main/java/org/apache/rocketmq/studio/cluster/k8s/InMemoryK8sCertRepository.java
index d5dc2933..622242c2 100644
---
a/server/src/main/java/org/apache/rocketmq/studio/cluster/k8s/InMemoryK8sCertRepository.java
+++
b/server/src/main/java/org/apache/rocketmq/studio/cluster/k8s/InMemoryK8sCertRepository.java
@@ -16,12 +16,9 @@
*/
package org.apache.rocketmq.studio.cluster.k8s;
-import org.apache.rocketmq.studio.common.domain.enums.CertStatus;
-import org.apache.rocketmq.studio.common.domain.enums.CertType;
import lombok.extern.slf4j.Slf4j;
import org.springframework.stereotype.Component;
-import java.time.LocalDateTime;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
@@ -34,10 +31,6 @@ public class InMemoryK8sCertRepository implements
K8sCertRepository {
private final Map<String, K8sCertVO> store = new ConcurrentHashMap<>();
- public InMemoryK8sCertRepository() {
- initStubData();
- }
-
@Override
public List<K8sCertVO> findAll() {
return new ArrayList<>(store.values());
@@ -60,60 +53,4 @@ public class InMemoryK8sCertRepository implements
K8sCertRepository {
store.remove(id);
log.info("Deleted certificate: {}", id);
}
-
- private void initStubData() {
- LocalDateTime now = LocalDateTime.now();
-
- K8sCertVO cert1 = K8sCertVO.builder()
- .name("rmq-proxy-tls")
- .namespace("rocketmq")
- .cluster("rmq-cluster-prod")
- .type(CertType.TLS)
- .issuer("letsencrypt-prod")
- .notBefore(now.minusDays(30))
- .notAfter(now.plusDays(60))
- .status(CertStatus.valid)
- .daysRemaining(60)
- .san(List.of("proxy.rmq.local", "*.proxy.rmq.local"))
- .build();
- cert1.setId("cert-001");
- cert1.setCreatedAt(now.minusDays(30));
- cert1.setUpdatedAt(now.minusDays(30));
-
- K8sCertVO cert2 = K8sCertVO.builder()
- .name("rmq-broker-mtls")
- .namespace("rocketmq")
- .cluster("rmq-cluster-prod")
- .type(CertType.mTLS)
- .issuer("internal-ca")
- .notBefore(now.minusDays(350))
- .notAfter(now.plusDays(15))
- .status(CertStatus.expiring)
- .daysRemaining(15)
- .san(List.of("broker-a.rmq.local", "broker-b.rmq.local"))
- .build();
- cert2.setId("cert-002");
- cert2.setCreatedAt(now.minusDays(350));
- cert2.setUpdatedAt(now.minusDays(350));
-
- K8sCertVO cert3 = K8sCertVO.builder()
- .name("rmq-staging-sa")
- .namespace("rocketmq-staging")
- .cluster("rmq-cluster-staging")
- .type(CertType.ServiceAccount)
- .issuer("k8s-self-signed")
- .notBefore(now.minusDays(400))
- .notAfter(now.minusDays(35))
- .status(CertStatus.expired)
- .daysRemaining(-35)
- .san(List.of("sa.rmq-staging.local"))
- .build();
- cert3.setId("cert-003");
- cert3.setCreatedAt(now.minusDays(400));
- cert3.setUpdatedAt(now.minusDays(400));
-
- store.put(cert1.getId(), cert1);
- store.put(cert2.getId(), cert2);
- store.put(cert3.getId(), cert3);
- }
}
diff --git
a/server/src/test/java/org/apache/rocketmq/studio/cluster/k8s/InMemoryK8sCertRepositoryTest.java
b/server/src/test/java/org/apache/rocketmq/studio/cluster/k8s/InMemoryK8sCertRepositoryTest.java
new file mode 100644
index 00000000..e2f0a916
--- /dev/null
+++
b/server/src/test/java/org/apache/rocketmq/studio/cluster/k8s/InMemoryK8sCertRepositoryTest.java
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.studio.cluster.k8s;
+
+import org.apache.rocketmq.studio.common.domain.enums.CertStatus;
+import org.apache.rocketmq.studio.common.domain.enums.CertType;
+import org.junit.jupiter.api.Test;
+
+import java.time.LocalDateTime;
+import java.util.List;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class InMemoryK8sCertRepositoryTest {
+
+ @Test
+ void repositoryShouldStartEmpty() {
+ InMemoryK8sCertRepository repository = new InMemoryK8sCertRepository();
+
+ assertThat(repository.findAll()).isEmpty();
+ }
+
+ @Test
+ void saveFindAndDeleteShouldManageExplicitRecordsOnly() {
+ InMemoryK8sCertRepository repository = new InMemoryK8sCertRepository();
+ K8sCertVO cert = K8sCertVO.builder()
+ .name("rocketmq-tls")
+ .namespace("rocketmq")
+ .cluster("prod")
+ .type(CertType.TLS)
+ .issuer("issuer")
+ .notBefore(LocalDateTime.now().minusDays(1))
+ .notAfter(LocalDateTime.now().plusDays(30))
+ .status(CertStatus.valid)
+ .daysRemaining(30)
+ .san(List.of("broker.example.com"))
+ .build();
+ cert.setId("cert-explicit");
+
+ repository.save(cert);
+
+ assertThat(repository.findAll()).containsExactly(cert);
+ assertThat(repository.findById("cert-explicit")).contains(cert);
+
+ repository.deleteById("cert-explicit");
+
+ assertThat(repository.findAll()).isEmpty();
+ assertThat(repository.findById("cert-explicit")).isEmpty();
+ }
+}
