RockteMQ-AI commented on issue #10788:
URL: https://github.com/apache/rocketmq/issues/10788#issuecomment-5163818683
**Issue Evaluation**
Category: `type/bug` | Status: **Confirmed**
The reported issue has been verified against the current codebase
(`develop@eddb235c1bd8`).
**Root Cause:** `GrpcClientSettingsManager.mergeMetric(...)` calls
`metricCollectorAddress.split(":")` and directly indexes `split[1]` without
validating that the address is non-blank or contains a colon. When
`metricCollectorMode=ON` and the address is blank or malformed, this throws
`ArrayIndexOutOfBoundsException` or `NumberFormatException`.
**Impact:** gRPC client settings generation fails entirely when metric
collector address is misconfigured, instead of gracefully degrading.
**Severity:** medium — requires misconfiguration to trigger, but the failure
is uncontrolled.
**File:**
`proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/common/GrpcClientSettingsManager.java`
(lines 120-122)
An automated fix proposal will be generated. Reply `/approve` to proceed
with PR generation.
---
*Automated evaluation by github-manager-bot*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
