Aias00 opened a new issue, #10797:
URL: https://github.com/apache/rocketmq/issues/10797

   ### What happened?
   
   `TransactionActivity` handles Proxy remoting end-transaction requests by 
calling `messagingProcessor.endTransaction(...)`, but it ignores the returned 
`CompletableFuture` and immediately returns a success response.
   
   The underlying transaction processor can complete the future exceptionally, 
for example when transaction data is missing or the broker operation fails. 
Those failures are not reflected on the remoting response path.
   
   ### Expected behavior
   
   Proxy remoting end-transaction handling should wait for the async result and 
map failures through the existing remoting exception mapping instead of 
returning success before the operation finishes.
   
   ### Scope
   
   RocketMQ Proxy / remoting transaction compatibility. This is related to the 
Proxy protocol upgrade track because remoting clients should receive accurate 
runtime operation results through Proxy.
   
   ### Suggested fix
   
   Chain or wait on `messagingProcessor.endTransaction(...)` in the same style 
as other remoting activities that call async processor methods, and add tests 
for success and failure responses.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to