RockteMQ-AI commented on issue #10813: URL: https://github.com/apache/rocketmq/issues/10813#issuecomment-5190409555
**Issue Evaluation** Category: `enhancement` | Status: **Evaluated** **Feasibility:** Feasible **Scope:** `store` module — LMQ append path (`LmqDispatch`) **Compatibility:** No public API, protocol, or persistence format changes Well-documented enhancement with solid JMH evidence (48-50% allocation reduction, 63-83% throughput improvement). The proposed approach of reusing parsed queue names and building offset properties with `StringBuilder.append(long)` is sound. The regression coverage plan (20 tests, mixed LMQ/non-LMQ, legacy property bytes, `END_OF_FILE` retry) is thorough. This is a good candidate for a PR. The implementation should: 1. Parse queue names once in the preparation phase 2. Build `PROPERTY_INNER_MULTI_QUEUE_OFFSET` with `StringBuilder` directly 3. Ensure `END_OF_FILE` retry path falls back to re-parsing 4. Keep existing public methods and property ordering unchanged --- *Automated evaluation by @RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
