ai-yang commented on PR #10814: URL: https://github.com/apache/rocketmq/pull/10814#issuecomment-5192106948
Thanks @fuyou001 — addressed in `b28b13f7b`. - `prepareLmqDispatch()` now only prepares queue names and offsets. - The legacy `WAIT_STORE_MSG_OK` remove/reinsert is isolated in `reinsertWaitStorePropertyForLegacySerialization()` and invoked immediately before the final `messageProperties2String()` call. - The byte-level regression test was renamed to `testCommitLogPreservesLegacyPropertyBytesAndIncrementsOffsetOnce` to make the compatibility guarantee explicit; its exact legacy property-string and persisted-byte assertions are retained. Validation on JDK 8: `LmqDispatchTest` 100/100 across 20 independent Maven processes; affected reactor 733 tests with 0 failures/errors (4 existing skips); Checkstyle, SpotBugs, store-scoped RAT, and `git diff --check` all passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
