RockteMQ-AI commented on issue #10791: URL: https://github.com/apache/rocketmq/issues/10791#issuecomment-5192793553
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** The reported issue has been verified against the current codebase. **Root Cause:** `ClientManagerActivity.heartBeat()` (line 80) calls `HeartbeatData.decode(request.getBody(), HeartbeatData.class)` and immediately dereferences the result at line 81 (`heartbeatData.getClientID()`) without a null check. `RemotingSerializable.decode()` returns `null` when the input body is `null`, so a malformed `HEART_BEAT` request with an empty or null body triggers a `NullPointerException` that surfaces as an internal proxy error. **Impact:** Proxy client-management path (`module/proxy`, `module/remoting`). Any client or tool that sends a malformed heartbeat frame can cause an unhandled exception in the proxy. **Severity:** Medium — does not crash the proxy, but produces misleading internal error responses and may leak stack trace details. **Suggested Fix:** Add a null check on the decoded `HeartbeatData` before dereferencing. Return a deterministic `INVALID_PARAMETER` response code with a clear remark when the body is null or undecodable. An automated fix proposal may be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
