fuyou001 opened a new issue, #10819:
URL: https://github.com/apache/rocketmq/issues/10819

   ### Search before creation
   
   - [x] I had searched in the issues and pull requests and found no similar 
report.
   
   ### Documentation Related
   
   In `store/src/main/java/org/apache/rocketmq/store/CommitLog.java`, 
`DefaultAppendMessageCallback#doAppend(...)` currently contains:
   
   ```java
   // Write messages to the queue buffer
   byteBuffer.put(preEncodeBuffer);
   ```
   
   The comment is misleading. The `byteBuffer` is the destination buffer 
supplied by `DefaultMappedFile#appendMessagesInner(...)` for copying the 
encoded message through the CommitLog write path. Depending on configuration, 
it can be backed by the mapped byte buffer, the transient write buffer, or a 
shared staging buffer used by the `writeWithoutMmap` path. It is not a queue or 
ConsumeQueue buffer.
   
   The comment should describe copying the encoded message into the current 
CommitLog write buffer. This is a documentation-only correction and does not 
change runtime behavior.
   
   ### Are you willing to submit PR?
   
   - [x] Yes I am willing to submit a PR!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to