RockteMQ-AI commented on issue #10817: URL: https://github.com/apache/rocketmq/issues/10817#issuecomment-5199913004
**Issue Evaluation** Category: `enhancement` | Status: **Confirmed** Verified against the codebase: - `pom.xml:173` pins `spotbugs-plugin.version` to `4.2.2` - `pom.xml:454` configures `<spotbugsXmlOutput>true</spotbugsXmlOutput>` which is unknown to newer versions - `remoting/.../NettyRemotingClient.java:183` uses `new Random()` in `initValueIndex()` — this triggers the `DMI_RANDOM_USED_ONLY_ONCE` finding that newer SpotBugs will flag The proposed changes are well-scoped and valid: 1. Upgrade `spotbugs-maven-plugin` from `4.2.2` → `4.8.6.8` (JDK 21 compatible, still supports JDK 8 runtime) 2. Remove obsolete `<spotbugsXmlOutput>` parameter 3. Fix additional findings (e.g., replace `new Random()` with `ThreadLocalRandom.current()` in `initValueIndex()`) This is a legitimate compatibility improvement. The analysis and proposed fix are thorough. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
