RockteMQ-AI commented on issue #1116: URL: https://github.com/apache/rocketmq-dashboard/issues/1116#issuecomment-5202070913
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The issue is valid. Both `TopicController` and `ConsumerController` accept write operations (create, update, import, delete, resetOffset) without verifying that a managed instance has been selected. The `createOrUpdate.do` endpoint in `TopicController` validates `brokerNameList`/`clusterNameList` but does not check for instance context. Similarly, `ConsumerController` write endpoints lack instance-scope guards. **Root Cause:** No instance-id validation in write-path controllers. The frontend can submit requests without `instanceId` while the instance list is loading or unavailable. **Impact:** Metadata may be persisted without proper instance scope, potentially falling back to a global/default control-plane target. **Severity:** medium-high Disabling write controls until an instance is selected, and guarding submit handlers server-side, is the correct approach. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
