RockteMQ-AI commented on code in PR #1233:
URL:
https://github.com/apache/rocketmq-dashboard/pull/1233#discussion_r3734488228
##########
server/src/main/java/org/apache/rocketmq/studio/instance/topic/LiteTopicService.java:
##########
@@ -37,10 +37,10 @@ public LiteTopicSessionVO getSession(String sessionId) {
public void extendTTL(String topicPattern, Long newTTL) {
if (topicPattern == null || topicPattern.isBlank()) {
- throw new IllegalArgumentException("topicPattern is required");
+ throw new BusinessException(400, "topicPattern is required");
Review Comment:
**[Info]** Consider extracting the `400` literal into a named constant (e.g.
`BAD_REQUEST`) for consistency with the `NOT_IMPLEMENTED` constant used on line
43. Minor readability improvement — not blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
