yyqdbngt opened a new pull request, #1252: URL: https://github.com/apache/rocketmq-dashboard/pull/1252
The metrics query exchange parsed the response body before checking the HTTP status, so a non-JSON error body (proxy HTML page, plain-text 503, ...) made JSON parsing throw and the error was reported as "Failed to connect to Prometheus" with the real upstream status lost. The status is now checked first, and a non-JSON error body reports the real upstream status while a non-JSON success body is rejected as malformed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
