tju-yxq opened a new pull request, #1436:
URL: https://github.com/apache/rocketmq-dashboard/pull/1436

   ## What is the purpose of the change
   
   Fixes #1435
   
   The DLQ resend outcome was `failed == 0 ? "SUCCESS" : "PARTIAL"`, 
misreporting zero matches as SUCCESS and total failure as PARTIAL.
   
   ## Brief changelog
   
   - **`RocketMQDLQProvider.java`**: Added `classifyOutcome()` method that 
returns `NO_MESSAGES` when matched=0, `FAILED` when all resends fail, `PARTIAL` 
when some fail, and `SUCCESS` when all succeed.
   - Updated both the response builder and audit recording to use the new 
classification.
   
   ## Verifying this change
   
   1. Trigger DLQ resend with no dead letters: outcome should be `NO_MESSAGES`.
   2. Trigger with all failures: outcome should be `FAILED`.
   3. Trigger with mixed: outcome should be `PARTIAL`.
   4. Trigger with all success: outcome should be `SUCCESS`.
   
   - [x] Make sure there is a Github issue filed for the change.
   - [x] Format the pull request title like `[ISSUE #1435] ...`.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction.
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass.
   - [ ] If this contribution is large, please file an Apache Individual 
Contributor License Agreement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to