tju-yxq opened a new pull request, #1446: URL: https://github.com/apache/rocketmq-dashboard/pull/1446
## What is the purpose of the change Fixes #1445 `listConsumerGroups()` called `enrichGroupWithConnectionInfo()` for every group, making 2 admin API calls per group (N+1 problem). For 100 groups, this meant 200 admin calls and minutes-long page load. ## Brief changelog - **`RocketMQMetadataProvider.java`**: Removed the `enrichGroupWithConnectionInfo` call from `listConsumerGroups()`. Live data (online instances, lag) is only fetched when viewing a single group's detail page via `getConsumerGroup()`. ## Verifying this change 1. Open consumer group list page with 50+ groups. 2. Before fix: page takes minutes to load. 3. After fix: page loads instantly (DB-only, no admin calls). 4. Click into a group detail: live data still loads correctly. - [x] Make sure there is a Github issue filed for the change. - [x] Format the pull request title like `[ISSUE #1445] ...`. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
