youngkermit8-coder opened a new issue, #1568:
URL: https://github.com/apache/rocketmq-dashboard/issues/1568

   ## Problem
   
   `RocketMQDashboardProvider` marks a cluster as `warning` when its master 
broker runtime metrics are unavailable, but `DashboardStatsVO.healthyClusters` 
is always set to `totalClusters`.
   
   This makes the summary health count disagree with the per-cluster status and 
can report a failed/unreachable cluster as healthy.
   
   ## Reproduction
   
   1. Return one cluster with one master broker from 
`examineBrokerClusterInfo()`.
   2. Make `fetchBrokerRuntimeStats(masterAddr)` throw (for example, the broker 
is temporarily unavailable).
   3. Call `getDashboardData()`.
   
   Current result:
   - the cluster overview status is `warning`;
   - `totalClusters` is `1`;
   - `healthyClusters` is also incorrectly `1`.
   
   Expected result:
   - `healthyClusters` is derived from the collected cluster statuses and is 
`0` in this case.
   
   ## Proposed fix
   
   Count `ClusterStatus.healthy` entries after building the cluster overviews 
and add regression assertions for both the healthy and warning paths.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to