messere1 opened a new pull request, #10903:
URL: https://github.com/apache/rocketmq/pull/10903
## What changed
- parse metrics labels and OTLP exporter headers at the first colon only
- trim keys and values while preserving additional colons in values
- skip entries with a missing separator or blank key
- report only the invalid entry position, without echoing the configured
header string
- add focused tests for colon-containing values, whitespace, empty values,
and malformed entries
## Why
Proxy metrics initialization previously used String.split(:). Valid header
values containing colons were discarded, and malformed OTLP header warnings
logged the complete configuration, which can include authorization tokens or
API keys.
## Impact
The change is local to Proxy metrics key/value parsing. It does not alter
exporter defaults, protocols, or public APIs.
Fixes #10901
## Validation
- mvn -pl proxy -Dtest=ProxyMetricsManagerTest -Djacoco.skip=true test
- 3 tests, 0 failures, 0 errors
- Checkstyle: 0 violations
- SpotBugs: 0 issues
JaCoCo is skipped locally because the repository's JaCoCo 0.8.5 agent does
not support Java 17 class files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
