lizhimins opened a new pull request, #1571: URL: https://github.com/apache/rocketmq-dashboard/pull/1571
## Summary Follow-up to the recent batch merges: fixes the remaining test regressions and the SSRF loopback guard conflict that were not covered by #1535's build fix. ## Changes - `SettingsService`: SSRF guard now rejects loopback IPs (127.x.x.x, ::1) in addition to `localhost` and link-local addresses; `isAllowedDataSourceHost` becomes package-private so tests can admit the loopback-bound embedded test server - `SettingsServiceTest`: override admits only the embedded test server, production guard unchanged - `RocketMQDLQProviderTest`: align outcome expectations with implementation semantics (`NO_MESSAGES` / `FAILED`) - `GrafanaDashboardList.test.tsx`: fix "Export all" button matcher index shift and clear mocks between cases - `message.tsx`: remount by `selectedInstanceId` key so stale instance results are cleared on route switch (React key-reset pattern) - `cluster/index.tsx`: add missing `.catch` on `listInstances` to avoid unhandled rejections - `RocketMQMessageProvider`: clarify offset-id lookup comment ## Verification - Backend: `mvn -T 32 test` 888/888 passed - Frontend: `npm run build` OK; vitest 492/493 passed (the single failure is the known TopicPage regression introduced by #1535, tracked separately) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
