youngkermit8-coder opened a new pull request, #1578:
URL: https://github.com/apache/rocketmq-dashboard/pull/1578

   ## Summary
   
   - initialize the Topic table loading state as inactive
   - enter the loading state only when a selected instance triggers `listTopics`
   - remove the phantom spinner from the no-instance empty state
   
   ## Root cause
   
   #1535 deferred the no-instance reset with `setTimeout(0)` while `TopicPage` 
still initialized `loading` to `true`. The empty Topic state could therefore 
render with an active spinner even though no Topic request was sent.
   
   Initializing the request-specific loading state to `false` preserves the 
existing effect behavior: selecting an instance sets it to `true` immediately 
before the Topic request, and completion clears it. With no instance, the table 
remains idle and write actions stay disabled.
   
   Fixes #1577.
   
   ## Verification
   
   ```text
   npm test -- src/pages/instance/__tests__/TopicPage.test.tsx
   Test Files  1 passed (1)
   Tests       9 passed (9)
   
   npm exec eslint -- src/pages/instance/topic.tsx 
src/pages/instance/__tests__/TopicPage.test.tsx
   passed
   
   npm run build
   passed
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to