messere1 opened a new pull request, #1596: URL: https://github.com/apache/rocketmq-dashboard/pull/1596
## Summary - track whether shared instance discovery failed - preserve the instance ID from an instance-scoped route when discovery is unavailable - retain successful-discovery validation and unknown-route fallback behavior - add a focused regression test for the failed-discovery path ## Root cause `useInstanceFilter` only accepted a routed instance ID when it appeared in the discovered instance list. A failed `listInstances()` call left that list empty, so the hook discarded the explicit route context despite its documented fallback behavior. ## User impact Instance-scoped Topic, Consumer, Message, ACL, DLQ, and Resource Plan pages can continue using their routed instance when the shared discovery endpoint is temporarily unavailable. Closes #1595 ## Validation - `npm test -- --run src/hooks/useInstanceFilter.test.tsx` (3 tests passed) - `npx eslint src/hooks/useInstanceFilter.ts src/hooks/useInstanceFilter.test.tsx --max-warnings=0` - `npx prettier --check src/hooks/useInstanceFilter.ts src/hooks/useInstanceFilter.test.tsx` - `npm run build` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
