youngkermit8-coder opened a new pull request, #1672: URL: https://github.com/apache/rocketmq-dashboard/pull/1672
## What changed - accept `instanceIds` in metrics data source create and update requests - copy the bindings into `DataSourceVO` so the existing repository persists them - cover both create and update controller paths with regression assertions ## Why The Settings UI already sends selected instance bindings, and metrics queries enforce `DataSourceVO.instanceIds`. `DataSourceDTO` omitted the field, so Jackson discarded it before `SettingsService` received the request. Sources configured for specific instances were silently stored as globally available. This PR restores the missing request-to-domain mapping. It does not change binding enforcement or the existing global behavior for a missing or empty list. Closes #1670. ## Validation - regression assertions first failed on upstream `9371e2a`: create and update both passed `instanceIds=null` to `SettingsService` - `mvn -B -ntp -Dtest=SettingsControllerTest test` — 21/21 passed - settings, persistence, and metrics query regression set — 73/73 passed - `mvn -B -ntp -DskipTests package` — passed; Checkstyle 0 violations - `mvn -q test` — 956/958 passed; the two failures are existing `ToolGatewayServiceTest` baseline failures independently reproduced on exact upstream `9371e2a` - branch fast-forwarded to current `rocketmq-studio` `5edf208`; the intervening upstream commit changes only Cluster frontend files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
