youngkermit8-coder opened a new pull request, #1681: URL: https://github.com/apache/rocketmq-dashboard/pull/1681
## What changed - prompt for username/password before activating a Basic Auth metrics data source - prompt for a bearer token before activating a Bearer Token metrics data source - attach credentials only to requests for the currently selected data source - clear credentials when leaving the source or unmounting Metrics Explorer - keep credentials out of Settings, browser storage, and URLs - document that data-source query credentials are supplied per request and never persisted ## Why Settings supports `Basic Auth` and `Bearer Token` data sources, and the backend accepts credentials per query because secrets are intentionally not persisted. Metrics Explorer previously selected these sources and queried immediately without collecting or sending credentials, so authenticated Prometheus-compatible sources could not be used from the UI. Closes #1678. ## Validation - `vitest run src/components/__tests__/MetricsExplorer.test.tsx` — 10 passed - changed-file ESLint — passed - `npm run build` — passed - full frontend suite — 506 passed, 1 unrelated baseline failure in `TopicPage > disables Topic writes until an instance is available`; the same failure reproduces on exact upstream commit `65d1c32` - full-repository ESLint remains blocked by two existing `react-hooks/set-state-in-effect` errors in `src/pages/instance/consumer.tsx`; changed-file ESLint is clean -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
