messere1 opened a new pull request, #1688: URL: https://github.com/apache/rocketmq-dashboard/pull/1688
## Summary - always remove the temporary download anchor after activation attempts - always revoke the Blob URL even when browser download activation throws - continue propagating the original error so existing callers can report export failure - cover the exceptional cleanup path with a regression test ## Root cause and impact Cleanup followed `anchor.click()` without a `finally` block. A blocked or failed browser activation therefore skipped both cleanup operations, leaving a hidden DOM node and Blob-backed URL allocated after every failed export. The shared helper now preserves the same success path and guarantees cleanup. Closes #1686 ## Validation - npm test -- --run src/utils/download.test.ts (2 passed) - npx eslint src/utils/download.ts src/utils/download.test.ts - npm run build - git diff --check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
