RockteMQ-AI commented on issue #1812:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/1812#issuecomment-5254291443

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The reported test failures are valid and reproducible.
   
   **Root Cause:** 
   1. `AuthControllerTest.logoutShouldReturnReturnSuccess` fails because the 
test sends `Bearer token-1` without stubbing `AuthService.isAuthenticated` for 
that token, causing the interceptor to reject with 401.
   2. `AuthCredentialAuthorizationIntegrationTest` cases fail because 
`AclController` now requires `ApacheAclReadService`, but the focused MVC slice 
doesn't provide a mock for that collaborator.
   
   **Impact:** Authentication MVC slice tests are broken, preventing validation 
of auth-related changes.
   
   **Severity:** Medium — blocks test-driven development and CI validation for 
authentication features.
   
   **Suggested Fix:** 
   1. Stub `AuthService.isAuthenticated` to return true for the test token in 
`AuthControllerTest`.
   2. Add `@MockBean ApacheAclReadService` to 
`AuthCredentialAuthorizationIntegrationTest`.
   
   An automated fix proposal can be generated. Reply `/approve` to proceed with 
PR generation.
   
   ---
   *Automated evaluation by github-manager*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to