yyqdbngt opened a new pull request, #1952: URL: https://github.com/apache/rocketmq-dashboard/pull/1952
## What is the purpose of the change Two correctness bugs in topic / consumer group management that can corrupt broker configuration or data: - `deleteTopic` and `deleteConsumerGroup` removed the resource from the brokers of **every** cluster sharing the NameServer, while create/update only ever touch the owning cluster. With cluster-scoped resource names, deleting a topic or group in one cluster silently deleted the same-named resource on other clusters' brokers, and could also fail with `TOPIC_NOT_EXIST` when the neighbor cluster had no such resource. - `updateTopic` reset `writeQueues`/`readQueues` to the default `8` whenever the request did not include queue counts (e.g. a perm or remark-only update), silently resizing the live topic and the stored record. ## Brief changelog - Scope `deleteTopic` and `doDeleteConsumerGroup` broker deletes to the owning cluster via `getMasterBrokerAddrsForCluster`, matching create/update. - Preserve the existing queue counts on `updateTopic` when the request omits them, matching the existing `perm` semantics. - Cover both fixes with unit tests: a two-cluster topology asserting the foreign cluster's broker is untouched, and a partial-update asserting 16/16 queues survive a perm-only change. ## Verifying this change - `mvn -q -Dtest=RocketMQAdminClientImplTest test` - `mvn -q test` (1057/1057) - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
