yyqdbngt opened a new pull request, #1977: URL: https://github.com/apache/rocketmq-dashboard/pull/1977
## What is the purpose of the change The dashboard counts topics from each master broker's `getAllTopicConfig` table, filtering with `SystemTopicFilter.isSystem(topic)` (single-arg). That overload treats a topic whose name equals a broker name (e.g. `broker-a`) as a user topic, so every broker's self-named stats topic inflated the global and per-cluster topic counts. The sibling `RocketMQMetadataProvider` already passes the broker name set to `isSystem(topic, brokerNames)` precisely to exclude these. ## Brief changelog - Pass the owning cluster's broker name set into `SystemTopicFilter.isSystem` when filtering dashboard topics, excluding broker-named stats topics. - Add `RocketMQDashboardProviderTest.dashboardShouldExcludeBrokerNamedStatsTopics`. ## Verifying this change - `mvn -q -Dtest=RocketMQDashboardProviderTest test` - `mvn -q test` (1055/1055) - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
