RockteMQ-AI commented on issue #1965:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/1965#issuecomment-5262511545

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The reported issue has been verified against the metrics data source status 
handling.
   
   **Root Cause:** The persisted metrics data source contract does not compute 
or return a health status field. Newly created and reloaded data sources have a 
`null` status. The Settings page passes this missing value to the `StatusBadge` 
component, whose fallback behavior is to display "offline", incorrectly 
suggesting an outage for untested data sources.
   
   **Impact:** Operators see false outage indicators for data sources that have 
simply not been tested yet, creating confusion and unnecessary alarm.
   
   **Severity:** Low — display issue with no data loss or functional impact, 
but misleading UX
   
   **Proposed Fix Assessment:** The proposed fix is appropriate:
   - Render missing/unknown status as "not tested" or "unavailable" instead of 
"offline"
   - Preserve existing status badge behavior for known values
   - Add a frontend test covering the real API shape without a status field
   
   An automated fix proposal can be generated. Reply `/approve` to proceed with 
PR generation.
   
   ---
   *Automated evaluation by github-manager-bot*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to