RockteMQ-AI commented on issue #1954:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/1954#issuecomment-5262986977

   **Issue Evaluation**
   
   Category: `type/enhancement` | Status: **Evaluated**
   
   **Feasibility:** Feasible
   **Scope:** Helm chart (`values.yaml`, `templates/studio-deployment.yaml`) 
and Docker entrypoint
   **Compatibility:** No breaking changes — additive only
   
   This is a well-reasoned request. The current single `exec` probe on `curl 
/actuator/health` conflates two distinct failure modes:
   
   - **Liveness** — process is running and can make progress (restart if 
deadlocked)
   - **Readiness** — application is ready to accept traffic (remove from 
Service endpoints if not)
   
   Separating them is a Kubernetes best practice and would prevent cascading 
restarts during slow startup or temporary dependency unavailability. The 
proposed approach (HTTP GET `/actuator/health/liveness` and 
`/actuator/health/readiness` with Spring Boot Actuator health indicators) is 
the standard pattern.
   
   **Suggested implementation:**
   1. Add Spring Boot Actuator health indicators for `liveness` and `readiness` 
endpoints (or use the built-in ones if already on Spring Boot 2.3+)
   2. Update Helm values to expose separate `livenessProbe` and 
`readinessProbe` configurations
   3. Keep backward compatibility by defaulting to the current single-probe 
behavior when the new values are not set
   
   ---
   *Automated evaluation by RockteMQ-AI*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to