Aias00 opened a new issue, #1994:
URL: https://github.com/apache/rocketmq-dashboard/issues/1994

   ## Problem
   
   `RocketMQAdminClientImpl.resetOffset()` catches every exception and replaces 
it with `BusinessException(500, "Failed to reset offset: ...")`.
   
   This also catches structured control-plane errors raised before any Broker 
call, including:
   
   - 400 when the selected instance has no endpoint
   - 404 when the selected instance does not exist
   - 422 when its `adminCredentialRef` is not configured
   
   The API therefore reports an internal server error instead of the actionable 
status and message already produced by `RuntimeAdminClientResolver`.
   
   ## Reproduction
   
   1. Call `POST /api/groups/reset-offset` with a syntactically valid request 
whose `instanceId` does not exist.
   2. `RuntimeAdminClientResolver` raises `BusinessException(404, "Instance not 
found: ...")`.
   3. `resetOffset()` catches it as a generic exception and returns code 500.
   
   ## Expected behavior
   
   - Existing `BusinessException` codes and messages are preserved.
   - Unexpected RocketMQ/Admin failures still become the current reset-offset 
500 response.
   - Both failed paths continue to produce a failed audit record.
   
   ## Scope
   
   Adjust the exception ordering in the Apache reset-offset implementation and 
add focused regression tests. No API shape or persistence change is required.
   
   Track 1: unified control plane Consumer Group operations and failure 
semantics.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to