tju-yxq commented on issue #1669: URL: https://github.com/apache/rocketmq-dashboard/issues/1669#issuecomment-5269287248
## Correction / closing I re-checked this report and the original technical premise is wrong. The issue claimed that `java.net.http.HttpClient` follows redirects by default. That is not true for Java 21: the official `HttpClient.Builder.followRedirects(...)` API documentation states that, when `followRedirects` is not invoked before `build()`, the default redirection policy is `HttpClient.Redirect.NEVER`. I also verified this locally with JDK 21 by printing `HttpClient.newBuilder().build().followRedirects()`, which returns `NEVER`. Therefore the reported redirect-based SSRF behavior is not a valid bug in `OpenAiCompatibleLlmClient`. PR #1671 only made the already-default safe behavior explicit; it should be understood as a defensive/readability hardening change, not as a fix for an actual redirect-following vulnerability. Closing this issue to avoid keeping an inaccurate security report open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
