123123213weqw opened a new pull request, #10917:
URL: https://github.com/apache/rocketmq/pull/10917
## What is the purpose of the change
Fix #10901.
ProxyMetricsManager parsed metricsGrpcExporterHeader entries with
item.split(":"), which drops any valid value containing a colon (e.g. a URI or
a structured authorization value). On a parse failure the warning logged the
complete header configuration, which may contain authorization tokens or API
keys. The same split behavior was also applied to metricsLabel.
## Brief changelog
- ProxyMetricsManager: split each entry at the first colon with split(":",
2) so header values may contain colons
- warning logs now print only the offending entry instead of the full header
configuration
## How was this patch verified
- Code review: split(":", 2) keeps the rest of the value after the first
colon
- `git diff --check` clean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
