tju-yxq commented on PR #1779: URL: https://github.com/apache/rocketmq-dashboard/pull/1779#issuecomment-5269387645
This PR is being closed as already fixed by the merged #1652 change. The issue itself was valid, but the current `rocketmq-studio` base already contains the correct implementation and tests from #1652 (`01f629f1`, `fix(consumer): keep aggregated lag unknown when any queue is unknown`). That merged change includes regression coverage in `RocketMQMetadataProviderTest`: - `getTopicConsumersKeepsUnknownWhenAnyQueueLagIsUnknown()` - `getTopicConsumersStillSumsKnownQueueLags()` I also verified the focused test locally: ```bash mvn -DskipTests=false -Dtest=RocketMQMetadataProviderTest#getTopicConsumersKeepsUnknownWhenAnyQueueLagIsUnknown test ``` Result: `BUILD SUCCESS`, `Tests run: 1, Failures: 0, Errors: 0, Skipped: 0`. This PR is now dirty against base and duplicates the merged implementation, so closing is safer than rebasing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
