btlqql opened a new pull request, #2029: URL: https://github.com/apache/rocketmq-dashboard/pull/2029
## What is the purpose of the change Fix #2000. InstanceService.deleteInstance checked that an instance exists and has no managed resources before deleting it. InstanceRepository.deleteById returned void and MybatisPlusInstanceRepository discarded the affected-row count from MyBatis-Plus. If two delete requests ran concurrently for the same instance, both passed the existence check and both reported success. ## Brief changelog - InstanceRepository.deleteById now returns whether a row was actually deleted - MybatisPlusInstanceRepository returns deleteById() > 0 - InstanceService.deleteInstance throws 404 when the delete affected no rows, so the loser of a concurrent delete reports the real outcome ## How was this patch verified - Code review of the affected-row handling; InstanceServiceTest delete cases updated to stub the new return value - `git diff --check` clean -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
