tju-yxq opened a new pull request, #2030: URL: https://github.com/apache/rocketmq-dashboard/pull/2030
## What is the purpose of the change Follow-up coverage for the no-redirect HTTP request factories used by settings data-source tests, metrics queries, and proxy reload calls. This is a testability/refactor follow-up for the redirect hardening in #1516, #1648, and #1667. It was identified through code inspection and covered with focused unit tests. It was not live-tested against a broker, Prometheus server, proxy, or internal-network SSRF target. ## Brief changelog - Extracted the metrics no-redirect `SimpleClientHttpRequestFactory` override into a package-private factory class. - Extracted the proxy no-redirect `SimpleClientHttpRequestFactory` override into a package-private factory class. - Added focused tests proving those factories disable per-connection HTTP redirect following. - Re-ran the existing settings factory test and proxy service tests together with the new tests. ## Verification ```bash cd server mvn -DskipTests=false "-Dtest=DataSourceClientHttpRequestFactoryTest,org.apache.rocketmq.studio.cluster.metrics.NoRedirectClientHttpRequestFactoryTest,org.apache.rocketmq.studio.cluster.proxy.NoRedirectClientHttpRequestFactoryTest,ProxyAddressServiceTest" test ``` Result: `BUILD SUCCESS`; `Tests run: 13, Failures: 0, Errors: 0, Skipped: 0`. ## Notes - This PR does not claim a live SSRF reproduction. - Full project verification was not run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
