RockteMQ-AI commented on code in PR #2042:
URL:
https://github.com/apache/rocketmq-dashboard/pull/2042#discussion_r3769324967
##########
server/src/main/java/org/apache/rocketmq/studio/ops/ai/ClaudeCodeAgentProvider.java:
##########
@@ -171,12 +179,28 @@ private <T> T await(CompletableFuture<T> future) throws
IOException, Interrupted
try {
return future.get(OUTPUT_DRAIN_TIMEOUT_SECONDS, TimeUnit.SECONDS);
} catch (ExecutionException exception) {
+ if (hasCause(exception, OutputLimitException.class)) {
+ throw new LlmGatewayException(502,
"llm.provider.output_too_large",
Review Comment:
Consider overriding `skip()` and `available()` in BoundedProcessInputStream
to prevent callers from bypassing the byte counter. Not critical since current
callers only use `read(byte[], int, int)` via BufferedReader, but it hardens
the class against future use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
