btlqql commented on PR #2105: URL: https://github.com/apache/rocketmq-dashboard/pull/2105#issuecomment-5279238885
The automated review looked at the master branch, but this PR targets rocketmq-studio where web/src/pages/instance/acl.tsx lines 188-189 still call r.principal.toLowerCase() and r.resource.toLowerCase() without a null guard. The String(val).toLowerCase() wrapper the review mentions is in the user search filter, not the rule filter. This fix adds the missing guard for the rule filter on rocketmq-studio. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
