lizhimins commented on PR #1921: URL: https://github.com/apache/rocketmq-dashboard/pull/1921#issuecomment-5279577330
Closing: this PR conflicts with the newly merged instance model (#2050, "use the instance name as the immutable instance ID") in several fundamental ways, so it cannot be merged as-is: 1. Overwrite mode calls save(candidate) directly and can silently change the instance name, while updateInstance now explicitly rejects ID changes. 2. Rows without an id get UUID.randomUUID(), but the new model uses the user-provided name as the primary key and no longer generates UUIDs. 3. There is no duplicate-name check (findByName / requireUniqueInstanceName), so imports hit the uk_instance_name constraint as a raw DB error. 4. Lookups use findById instead of the new findByIdentifier (name-first) path. 5. Overwrite can change cloud instance endpoint/type, bypassing the cloud-instance protections in updateInstance/createCloudInstance. Additionally, the backend ignores schemaVersion entirely (only the frontend rejects v2). If you would like to rework this on top of #2050 (id=name, unique-name validation, identifier lookups, server-side schema version checks), we would be happy to review a new PR. Thanks for the solid export side and the dry-run design! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
