lizhimins commented on PR #2048: URL: https://github.com/apache/rocketmq-dashboard/pull/2048#issuecomment-5280256252
Merged with three maintainer adjustments: AclServiceTest updated for the new updateUser(user, instanceId) signature, isTencentInstance switched from findById to findByIdentifier (consistent with the identifier-first lookups introduced in #2050), and four AclPage.test.tsx payloads updated to include the new instanceId field. Non-blocking follow-up suggestion: a dedicated TencentAclServiceTest covering the Tencent routing branch would match the pattern of the other Tencent services. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
