btlqql opened a new pull request, #2175:
URL: https://github.com/apache/rocketmq-dashboard/pull/2175

   ## Summary
   
   - require suffixed Prometheus duration parts to use integer values
   - enforce longest-to-shortest unit order and reject repeated units
   - retain support for bare numeric seconds and valid combined durations
   
   ## Root cause
   
   The local step parser summed every matched duration part independently. As a 
result, inputs such as `1s1h`, `1m1m`, and `1.5h` passed local validation even 
though Prometheus rejects them, moving a client error downstream to the data 
source.
   
   Closes #2174.
   
   ## Validation
   
   - `mvn -Dtest=MetricsServiceTest test` (22 tests passed)
   - Maven Checkstyle validation (0 violations)
   - `git diff --check`
   - both changed paths checked against all open PRs targeting 
`rocketmq-studio` (no matches)
   
   The accepted grammar follows the Prometheus duration rule that combined 
units are ordered longest to shortest and each unit appears at most once.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to