RockteMQ-AI commented on PR #1339: URL: https://github.com/apache/rocketmq-clients/pull/1339#issuecomment-5292370026
## Re-review after update Thanks for addressing the previous feedback. The changes in `ecdedf22` look good: 1. **`putAllIfAbsent` allocation fix** ✅ — The early-return scan before allocating the `LinkedHashMap` copy eliminates unnecessary allocations on the hot path when no new metrics are present. Clean implementation. 2. **`formatBoundary` comment** ✅ — The added comment clarifies the encoding scheme (`-1.5 → n1_5`), which is helpful for future readers. No new issues found. The implementation is solid. --- *Automated re-review by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
