RockteMQ-AI commented on issue #2185: URL: https://github.com/apache/rocketmq-dashboard/issues/2185#issuecomment-5292617371
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** The Tencent ACL partial update logic has two distinct bugs: (1) requiring `username` when `id` should suffice as the role identifier, and (2) converting omitted nullable permission fields to `true` instead of preserving existing values. **Root Cause:** `TencentAclService.updateUser()` uses `username` as the role key and applies `true` as default for null permission fields instead of fetching current values. **Impact:** Partial ACL updates either fail validation or silently enable permissions the user intended to leave unchanged. **Severity:** medium Suggested fix: Fall back to role id when username is absent, and fetch existing permissions before merging partial updates. An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
