yyqdbngt commented on PR #1923: URL: https://github.com/apache/rocketmq-dashboard/pull/1923#issuecomment-5312093691
Addressed the review feedback (all items): **Required** 1. Repository-layer tests added in `MybatisPlusAuditRepositoryTest`: result aggregation, hotspot ordering, the top-N dashboard limit, case-insensitive aggregate label mapping, and filter propagation across every aggregate query. 2. `uniqueOperators` is now `COUNT(DISTINCT operator)` evaluated in SQL (no rows pulled into memory). **Recommended** 3. The four per-outcome `COUNT(*)` statements are merged into a single `GROUP BY result` query (7 -> 5 round trips per summary request). 4. Backend hotspot limit aligned with the dashboard top-N list (`HOTSPOT_LIMIT`). 5. `summaryLoading` is reset when the filters change (microtask mirrors the record-list effect), so a stale summary is not shown while the refreshed aggregate loads. 6. Comment added noting that when the caller filters by `result`, the other outcome buckets are intentionally zero. **Verified locally** - `mvn test -Dtest=*Audit*` -> 31/31 pass (BUILD SUCCESS) - `npx vitest run` audit page + api -> 11/11 pass - `npx eslint` clean, `prettier` clean, `git diff --check` clean Ready for re-review. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
