Aias00 commented on issue #2337: URL: https://github.com/apache/rocketmq-dashboard/issues/2337#issuecomment-5323910129
Thanks for the review. This report targets the `rocketmq-studio` branch, not the repository default branch. The affected implementation is present on that branch: - `server/src/main/java/org/apache/rocketmq/studio/ops/ai/AiController.java` exposes the AI tool execution endpoint. - `server/src/main/java/org/apache/rocketmq/studio/ops/ai/tool/MessageQueryToolHandler.java` and `MessageTraceToolHandler.java` accept the supplied offset-style `msgId`. - `server/src/main/java/org/apache/rocketmq/studio/provider/apache/RocketMQMessageProvider.java` decodes that ID and calls `DefaultMQAdminExt.viewMessage` at the decoded broker address. Before the fix, this address was not verified against the broker endpoints advertised by the selected Studio instance. PR #2339 fixes the issue on `rocketmq-studio`: it validates the decoded message-ID endpoint against the selected instance's discovered broker metadata before making the remoting call, and adds regression coverage for an ID whose embedded address is not a known broker. The PR is ready, mergeable, and all CI checks are passing. Please evaluate the report and PR against `rocketmq-studio`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
