The GitHub Actions job "Build and Run Tests by Bazel" on 
rocketmq.git/codex/dledger-latest-pr336-adapter has succeeded.
Run started by GitHub user RongtongJin (triggered by RongtongJin).

Head commit for run:
d723895a38f5a2cc2d6f663481a9f727a177d373 / 通融 <[email protected]>
fix: restore divided-commitlog fallback in DLedgerCommitLog#getMaxOffset

getCommittedPos() returns a negative value when no entry has been
committed yet, which is exactly the state of a freshly started DLedger
store layered on top of legacy commitlog data. The `committedPos == 0`
guard therefore skipped the dLedgerFileList.getMinOffset() fallback that
was previously applied for any non-positive committed position, so
getMaxOffset() and getConfirmOffset() returned 0 instead of the divided
commitlog offset. DefaultMessageStore then computed a negative
dispatchBehindBytes() and left reputFromOffset behind, failing
MixCommitlogTest#testPutAndGet with expected:<0> but was:<-1163232>.

Also make StoreTestBase#nextPort() probe that a candidate port can
actually be bound before handing it out. The counter previously returned
port numbers blindly, so a stale listener in the 30000+ range made
callers fail with "Address already in use"; the new three-node DLedger
test needs three listeners at once and hit this on CI.

Report URL: https://github.com/apache/rocketmq/actions/runs/32123898079

With regards,
GitHub Actions via GitBox

Reply via email to