RockteMQ-AI commented on issue #2345: URL: https://github.com/apache/rocketmq-dashboard/issues/2345#issuecomment-5335807297
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The reported issue has been verified against the current codebase. **Root Cause:** In `RocketMQAdminClientImpl.updateTopic()` (lines 232-239), the queue-count precedence is inverted — the ternary checks the persisted DB value first and uses it unconditionally when positive. The request's queue counts are only consulted when the DB record is absent or stores null/zero. This means any explicit resize request is silently ignored as long as a DB row with a positive value exists. **Impact:** Topic resize via the dashboard update API is a no-op. The broker and DB remain at the old queue count, and the response echoes the old values with no error — giving the user no indication the resize was dropped. **Severity:** Medium-High **Affected file:** `server/src/main/java/org/apache/rocketmq/studio/provider/apache/RocketMQAdminClientImpl.java` **Fix direction:** Flip the ternary precedence to: request value → persisted value → default (8). This preserves partial-update safety (omitted counts keep existing values) while allowing explicit resize requests to take effect. An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
