RockteMQ-AI commented on issue #2420: URL: https://github.com/apache/rocketmq-dashboard/issues/2420#issuecomment-5351224180
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The reported issue has been verified against the codebase (in `rocketmq-studio` branch). **Root Cause:** `InstanceService.deleteInstances(List<String> instanceIds)` does not normalize or de-duplicate the input list before processing: - No de-duplication: repeated IDs like `["inst-a", "inst-a"]` are processed twice, causing misleading success/failure counts - No pre-validation: all-blank input like `["", " "]` passes the initial null/empty check and returns `deleted=0, failed=[]` instead of a 400 error - Trimming happens per-item inside the loop but after the initial validation gap **Impact:** Incorrect deletion counts; inconsistent API contract; potential confusion in audit logs. **Severity:** Medium - incorrect response data but no data loss (deletions are idempotent). **Note:** PR #2421 already addresses this fix. --- *Automated evaluation by github-manager* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
