RockteMQ-AI commented on issue #2497:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/2497#issuecomment-5368444925

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The reported issue has been verified against the current codebase.
   
   **Root Cause:** In `RocketMQAdminClientImpl.updateTopic()` (line ~266), the 
remark update is guarded by `if (StringUtils.hasText(topic.getRemark()))`. When 
a user submits an empty string to clear the remark, `StringUtils.hasText("")` 
returns `false`, so the old remark is preserved.
   
   **Impact:** Users cannot clear topic remarks through the Studio UI. Once 
set, a remark is permanent.
   
   **Severity:** low
   
   **Suggested Fix:** Distinguish `null` (field not submitted) from empty 
string (explicitly cleared). Update the remark when the field is non-null, 
normalizing an empty string to null/empty.
   
   An automated fix proposal will be generated. Reply `/approve` to proceed 
with PR generation.
   
   ---
   *Automated evaluation by github-manager*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to